# Re: \[PATCH v6 1/4\] block: add blk\_mq\_is\_queue\_frozen()

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2021-03-09 17:21:05 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2021/03/6294033
- Thread: https://ratatoskr.run/linux-block/2021/03/6286753/t.md

```text
On Wed, Mar 03, 2021 at 03:30:15PM +0300, Sergei Shtepa wrote:
> +bool blk_mq_is_queue_frozen(struct request_queue *q)
> +{
> +	bool ret;
> +
> +	mutex_lock(&q->mq_freeze_lock);
> +	ret = percpu_ref_is_dying(&q->q_usage_counter) && percpu_ref_is_zero(&q->q_usage_counter);

Please avoid the overly long line.

Also maybe frozen is a better name for the variable currently called
ret?
```