# Re: \[PATCH 05/19\] swim: use bdev\_check\_media\_change

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2020-09-02 15:31:57 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2020/09/187834
- Thread: https://ratatoskr.run/linux-block/2020/09/187819/t.md

```text
On Wed, Sep 02, 2020 at 03:30:14PM +0000, Johannes Thumshirn wrote:
> Looks good,
> Reviewed-by: Johannes Thumshirn <redacted>
> 
> > +static int floppy_revalidate(struct gendisk *disk);
> 
> Completely unrelated to this series but, this is the 3rd floppy 
> driver in the series defining it's own floppy_revalidate() and 
> naming it floppy_revalidate().
> 
> This makes grepping and reviewing a pain.

Yes, I noticed it as well.  They also use the floppy_ prefix for
various other methods.

> 
---end quoted text---
```