# Re: rename -\>make\_request\_fn and move it to the block\_device\_operations

- From: Jens Axboe \<axboe@kernel.dk\>
- Date: 2020-06-30 13:57:36 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2020/06/6020400
- Thread: https://ratatoskr.run/linuxppc-dev/2020/06/6018213/t.md

```text
On 6/29/20 1:39 PM, Christoph Hellwig wrote:
> Hi Jens,
> 
> this series moves the make_request_fn method into block_device_operations
> with the much more descriptive ->submit_bio name.  It then also gives
> generic_make_request a more descriptive name, and further optimize the
> path to issue to blk-mq, removing the need for the direct_make_request
> bypass.

Looks good to me, and it's a nice cleanup as well. Applied.

-- 
Jens Axboe
```
