# Re: \[PATCH V10 11/19\] bcache: avoid to use bio\_for\_each\_segment\_all() in bch\_bio\_alloc\_pages()

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2018-11-16 13:46:45 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2018/11/145832
- Thread: https://ratatoskr.run/linux-block/2018/11/146358/t.md

```text
> -	bio_for_each_segment_all(bv, bio, i) {
> +	for (i = 0, bv = bio->bi_io_vec; i < bio->bi_vcnt; bv++) {

This really needs a comment.  Otherwise it looks fine to me.
```
