# Re: \[PATCH V10 11/19\] bcache: avoid to use bio\_for\_each\_segment\_all() in bch\_bio\_alloc\_pages()

- From: Ming Lei \<hidden\>
- Date: 2018-11-19 08:27:23 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2018/11/145831
- Thread: https://ratatoskr.run/linux-block/2018/11/146358/t/2.md

```text
On Thu, Nov 15, 2018 at 04:44:02PM -0800, Omar Sandoval wrote:
> On Thu, Nov 15, 2018 at 04:52:58PM +0800, Ming Lei wrote:
> > bch_bio_alloc_pages() is always called on one new bio, so it is safe
> > to access the bvec table directly. Given it is the only kind of this
> > case, open code the bvec table access since bio_for_each_segment_all()
> > will be changed to support for iterating over multipage bvec.
> > 
> > Cc: Dave Chinner <redacted>
> > Cc: Kent Overstreet <redacted>
> > Acked-by: Coly Li <redacted>
> > Cc: Mike Snitzer <redacted>
> > Cc: <redacted>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: <redacted>
> > Cc: Shaohua Li <shli@kernel.org>
> > Cc: <redacted>
> > Cc: <redacted>
> > Cc: David Sterba <dsterba@suse.com>
> > Cc: <redacted>
> > Cc: Darrick J. Wong <redacted>
> > Cc: <redacted>
> > Cc: Gao Xiang <redacted>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Theodore Ts'o <tytso@mit.edu>
> > Cc: <redacted>
> > Cc: Coly Li <redacted>
> > Cc: <redacted>
> > Cc: Boaz Harrosh <redacted>
> > Cc: Bob Peterson <redacted>
> > Cc: <redacted>
> > Signed-off-by: Ming Lei <redacted>
> > ---
> >  drivers/md/bcache/util.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/md/bcache/util.c b/drivers/md/bcache/util.c
> > index 20eddeac1531..8517aebcda2d 100644
> > --- a/drivers/md/bcache/util.c
> > +++ b/drivers/md/bcache/util.c
> > @@ -270,7 +270,7 @@ int bch_bio_alloc_pages(struct bio *bio, gfp_t gfp_mask)
> >  	int i;
> >  	struct bio_vec *bv;
> >  
> > -	bio_for_each_segment_all(bv, bio, i) {
> > +	for (i = 0, bv = bio->bi_io_vec; i < bio->bi_vcnt; bv++) {
> 
> This is missing an i++.

Good catch, will fix it in next version.

thanks,
Ming
```
