# Re: \[PATCH V10 11/19\] bcache: avoid to use bio\_for\_each\_segment\_all() in bch\_bio\_alloc\_pages()

- From: Ming Lei \<hidden\>
- Date: 2018-11-19 08:28:20 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2018/11/145830
- Thread: https://ratatoskr.run/linux-block/2018/11/146358/t/2.md

```text
On Fri, Nov 16, 2018 at 02:46:45PM +0100, Christoph Hellwig wrote:
> > -	bio_for_each_segment_all(bv, bio, i) {
> > +	for (i = 0, bv = bio->bi_io_vec; i < bio->bi_vcnt; bv++) {
> 
> This really needs a comment.  Otherwise it looks fine to me.

OK, will do it in next version.

Thanks,
Ming
```
