# Re: \[PATCH V10 15/19\] block: always define BIO\_MAX\_PAGES as 256

- From: Omar Sandoval \<osandov@osandov.com\>
- Date: 2018-11-16 01:59:36 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2018/11/145729
- Thread: https://ratatoskr.run/linux-block/2018/11/146358/t.md

```text
On Thu, Nov 15, 2018 at 04:53:02PM +0800, Ming Lei wrote:
> Now multi-page bvec can cover CONFIG_THP_SWAP, so we don't need to
> increase BIO_MAX_PAGES for it.

You mentioned to it in the cover letter, but this needs more explanation
in the commit message. Why did CONFIG_THP_SWAP require > 256? Why does
multipage bvecs remove that requirement?

> Cc: Dave Chinner <redacted>
> Cc: Kent Overstreet <redacted>
> Cc: Mike Snitzer <redacted>
> Cc: <redacted>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: <redacted>
> Cc: Shaohua Li <shli@kernel.org>
> Cc: <redacted>
> Cc: <redacted>
> Cc: David Sterba <dsterba@suse.com>
> Cc: <redacted>
> Cc: Darrick J. Wong <redacted>
> Cc: <redacted>
> Cc: Gao Xiang <redacted>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Theodore Ts'o <tytso@mit.edu>
> Cc: <redacted>
> Cc: Coly Li <redacted>
> Cc: <redacted>
> Cc: Boaz Harrosh <redacted>
> Cc: Bob Peterson <redacted>
> Cc: <redacted>
> Signed-off-by: Ming Lei <redacted>
> ---
>  include/linux/bio.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 5040e9a2eb09..277921ad42e7 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -34,15 +34,7 @@
>  #define BIO_BUG_ON
>  #endif
>  
> -#ifdef CONFIG_THP_SWAP
> -#if HPAGE_PMD_NR > 256
> -#define BIO_MAX_PAGES		HPAGE_PMD_NR
> -#else
>  #define BIO_MAX_PAGES		256
> -#endif
> -#else
> -#define BIO_MAX_PAGES		256
> -#endif
>  
>  #define bio_prio(bio)			(bio)->bi_ioprio
>  #define bio_set_prio(bio, prio)		((bio)->bi_ioprio = prio)
> -- 
> 2.9.5
> 
```
