# Re: \[PATCH V10 15/19\] block: always define BIO\_MAX\_PAGES as 256

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2018-11-16 13:53:40 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2018/11/145728
- Thread: https://ratatoskr.run/linux-block/2018/11/146358/t.md

```text
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 5040e9a2eb09..277921ad42e7 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -34,15 +34,7 @@
>  #define BIO_BUG_ON
>  #endif
>  
> -#ifdef CONFIG_THP_SWAP
> -#if HPAGE_PMD_NR > 256
> -#define BIO_MAX_PAGES		HPAGE_PMD_NR
> -#else
>  #define BIO_MAX_PAGES		256
> -#endif
> -#else
> -#define BIO_MAX_PAGES		256
> -#endif

Looks good.  This mess should have never gone in.

Reviewed-by: Christoph Hellwig <hch@lst.de>
```
