# Re: \[PATCH V10 15/19\] block: always define BIO\_MAX\_PAGES as 256

- From: Ming Lei \<hidden\>
- Date: 2018-11-19 09:04:16 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2018/11/145727
- Thread: https://ratatoskr.run/linux-block/2018/11/146358/t/2.md

```text
On Thu, Nov 15, 2018 at 05:59:36PM -0800, Omar Sandoval wrote:
> On Thu, Nov 15, 2018 at 04:53:02PM +0800, Ming Lei wrote:
> > Now multi-page bvec can cover CONFIG_THP_SWAP, so we don't need to
> > increase BIO_MAX_PAGES for it.
> 
> You mentioned to it in the cover letter, but this needs more explanation
> in the commit message. Why did CONFIG_THP_SWAP require > 256? Why does
> multipage bvecs remove that requirement?

CONFIG_THP_SWAP needs to split one TH page into normal pages and adds
them all to one bio. With multipage-bvec, it just takes one bvec to
hold them all.

thanks,
Ming
```
