# Re: \[PATCH V12 09/20\] block: use bio\_for\_each\_bvec() to compute multi-page bvec count

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2018-11-26 13:11:20 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2018/11/145265
- Thread: https://ratatoskr.run/linux-block/2018/11/145684/t.md

```text
Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Nitpick below:

> +{
> +	unsigned len = bv->bv_len;
> +	unsigned total_len = 0;
> +	unsigned new_nsegs = 0, seg_size = 0;
> +
> +	/*
> +	 * Multipage bvec may be too big to hold in one segment,
> +	 * so the current bvec has to be splitted as multiple
> +	 * segments.
> +	 */

Please use up all 80 chars in a line.
```
