# Re: \[PATCHv2 1/2\] super1: ignore failfast flag for setting device role

- From: jes.sorensen@gmail.com
- Date: 2017-03-28 18:02:24 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2017/03/4965548
- Thread: https://ratatoskr.run/linux-raid/2017/03/4965548/t.md

```text
Gioh Kim [ref] writes:
> There is corner case for setting device role,
> if new device has failfast flag.
> The failfast flag should be ignored.
>
> Signed-off-by: Gioh Kim <redacted>
> Signed-off-by: Jack Wang <redacted>
> ---
>  super1.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Applied!

Ideally I would like to get rid of the hardcoded values and use the bit
defines instead, but the original code did the same, so I am going to
take it.

I am leaving out the second patch for now, per Neil's comments. If you
feel strongly about it, please conveince Neil first :)

Thanks,
Jes
```