# Re: \[PATCH 24/29\] drivers: convert iblock\_req.pending from atomic\_t to refcount\_t

- From: Nicholas A. Bellinger \<hidden\>
- Date: 2017-03-21 07:18:14 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2017/03/4959453
- Thread: https://ratatoskr.run/netdev/2017/03/4947373/t.md

```text
Hi Elena,

On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote:
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
> 
> Signed-off-by: Elena Reshetova <redacted>
> Signed-off-by: Hans Liljestrand <redacted>
> Signed-off-by: Kees Cook <redacted>
> Signed-off-by: David Windsor <redacted>
> ---
>  drivers/target/target_core_iblock.c | 12 ++++++------
>  drivers/target/target_core_iblock.h |  3 ++-
>  2 files changed, 8 insertions(+), 7 deletions(-)

After reading up on this thread, it looks like various subsystem
maintainers are now picking these atomic_t -> refcount_t conversions..

That said, applied to target-pending/for-next and will plan to include
for v4.12-rc1 merge window.

Thanks!

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
```
