# Re: split scsi passthrough fields out of struct request V2

- From: Jens Axboe \<hidden\>
- Date: 2017-01-27 17:33:49 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2017/01/6370283
- Thread: https://ratatoskr.run/linux-block/2017/01/6370318/t.md

```text
On 01/27/2017 09:34 AM, Christoph Hellwig wrote:
> On Fri, Jan 27, 2017 at 09:27:02AM -0700, Jens Axboe wrote:
>> Feel free to repost it, I have no problem rebasing that branch as it's
>> standalone for now.
> 
> Ok, I'll repost what I have right now, which is on top of a merge
> of your block/for-4.11/next and your for-next from this morning
> my time.

Perfect.

> Btw, I disagred with your patch to use op_is_flush in
> generic_make_request_checks - given that we clear these flags just
> below I think using the helper obsfucates what's really going on.

Why? It's the exact same check. The ugly part is the fact that
we strip the flags later on, imho.

-- 
Jens Axboe
```