# Re: \[PATCH 04/18\] block: simplify blk\_init\_allocated\_queue

- From: Martin K. Petersen \<hidden\>
- Date: 2017-01-26 03:02:54 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2017/01/6370242
- Thread: https://ratatoskr.run/linux-block/2017/01/6370242/t.md

```text
>>>>> "Christoph" == Christoph Hellwig [ref] writes:

Christoph> Return an errno value instead of the passed in queue so that
Christoph> the callers don't have to keep track of two queues, and move
Christoph> the assignment of the request_fn and lock to the caller as
Christoph> passing them as argument doesn't simplify anything.  While
Christoph> we're at it also remove two pointless NULL assignments, given
Christoph> that the request structure is zeroed on allocation.

Reviewed-by: Martin K. Petersen <redacted>

-- 
Martin K. Petersen	Oracle Linux Engineering
```