# Re: \[PATCH 04/18\] block: simplify blk\_init\_allocated\_queue

- From: Bart Van Assche \<hidden\>
- Date: 2017-01-26 23:27:33 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2017/01/6370241
- Thread: https://ratatoskr.run/linux-scsi/2017/01/6370318/t.md

```text
On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote:
> Return an errno value instead of the passed in queue so that the callers
> don't have to keep track of two queues, and move the assignment of the
> request_fn and lock to the caller as passing them as argument doesn't
> simplify anything.  While we're at it also remove two pointless NULL
> assignments, given that the request structure is zeroed on allocation.

Reviewed-by: Bart Van Assche <redacted>
```