# Re: \[PATCH 1/4 v2\] mdadm: bad block support for external metadata - initialization

- From: Jes Sorensen \<hidden\>
- Date: 2016-11-28 13:43:28 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2016/11/6633695
- Thread: https://ratatoskr.run/linux-raid/2016/11/6633695/t.md

```text
Jes Sorensen [ref] writes:
> Tomasz Majchrzak [ref] writes:
>> On Thu, Oct 27, 2016 at 10:53:42AM +0200, Tomasz Majchrzak wrote:
>>> If metadata handler provides support for bad blocks, tell md by writing
>>> 'external_bbl' to rdev state file (both on create and assemble),
>>> followed by a list of known bad blocks written via sysfs 'bad_blocks'
>>> file.
>>> 
>>> Signed-off-by: Tomasz Majchrzak <redacted>
>>> Reviewed-by: Artur Paszkiewicz <redacted>
>>> ---
>>>  mdadm.h | 13 +++++++++++++
>>>  sysfs.c | 29 ++++++++++++++++++++++++++++-
>>>  2 files changed, 41 insertions(+), 1 deletion(-)
>>
>> Hi Jes,
>>
>> Do you have any comments for this patch set? It is a generic code for bad
>> block support for external metadata. It comes ahead of my other patch set
>> which provides IMSM implementation of new functionality.
>>
>> Regards,
>>
>> Tomek
>
> Hi Tomek,
>
> I thought I had responded to this one - I'll have a look early next week
> (holiday here).

Tomek,

It mostly look fine, there is a nitpick in patch 1/4. In general I
discourage the use of unnecessary parenthesis in multi case if
statements, but it's not a showstopper. Ie.
 if ((foo == x) && (bar != y))

If you send me an updated 1/4 then I should be able to apply it.

and of course, always use a cover letter when sending out multi-patch
sets in the future.

Cheers,
Jes
```