# Re: md/raid1: Improve another size determination in setup\_conf()

- From: Jes Sorensen \<hidden\>
- Date: 2016-10-10 13:11:31 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2016/10/4850969
- Thread: https://ratatoskr.run/linux-raid/2016/10/4850969/t.md

```text
SF Markus Elfring [ref] writes:
>>>> but patches that just fix coding style are a bad thing
>>>
>>> When you find such a change opportunity so "bad", are there any 
>>> circumstances left over where you would dare to touch the corresponding 
>>> source code line.
>> 
>> If you actually rewrite the code or fix some real bug there.
>
> Do the proposed update steps 12 - 16 for the function "setup_conf"
> (in this software module) fit to your condition?
>
> Do you reject this update step?

I do - those changes do nothing to improve the code and simply hides a
lot of history.

Jes
```