# Re: \[PATCH 01/10\] dm snapshot: Use kmalloc\_array() in init\_origin\_hash()

- From: Paul Bolle \<hidden\>
- Date: 2016-09-29 21:42:59 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2016/09/4846360
- Thread: https://ratatoskr.run/linux-raid/2016/09/4845849/t.md

```text
On Thu, 2016-09-29 at 14:21 -0700, Joe Perches wrote:
> > > It doesn't matter match either way to me.
> > Why does this stop you fixing an apparently wrong checkpatch rule,
> > crude as parts of it are (ie, uppercase identifier must be a
> > constant)?
> 
> It doesn't.  It just doesn't matter much (match) to me.

Joe, please.

I've recently ping-ponged with the kernel's "resident wrong bot of the
day" over this very rule (kmalloc_array() is safer than kmalloc(), so
change your driver now!). Could we just give wrong bots a bit less
ammunition whenever that's feasible?

Even if you don't care about my ping-pong experiences: this checkpatch
test is broken, please just fix it!


Paul Bolle
```