# Re: \[PATCH 01/10\] dm snapshot: Use kmalloc\_array() in init\_origin\_hash()

- From: Joe Perches \<joe@perches.com\>
- Date: 2016-09-29 20:56:41 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2016/09/4846340
- Thread: https://ratatoskr.run/linux-raid/2016/09/4845849/t.md

```text
On Thu, 2016-09-29 at 22:39 +0200, Paul Bolle wrote:
> On Thu, 2016-09-29 at 13:24 -0700, Joe Perches wrote:
> > On Thu, 2016-09-29 at 21:43 +0200, Paul Bolle wrote:
> > > Why doesn't that regex match on "ORIGIN_HASH_SIZE"?
> > It does match.
> If that regex does match, it being part of a negative test, the
> specific checkpatch rule should be silent, shouldn't it?

'cause I forgot to trim() the original $4 and $10 matches.

Oh well.

It doesn't matter match either way to me.

The case for the unnecessary multiply with <= gcc 4.8 was
removed with:

commit 91c6a05f72a996bee5133e76374ab3ad7d3b9b72
Author: Alexey Dobriyan [ref]
Date:   Tue Jul 26 15:22:08 2016 -0700

    mm: faster kmalloc_array(), kcalloc()
    
    When both arguments to kmalloc_array() or kcalloc() are known at compile
    time then their product is known at compile time but search for kmalloc
    cache happens at runtime not at compile time.
    
    Link: http://lkml.kernel.org/r/20160627213454.GA2440@p183.telecom.by
    Signed-off-by: Alexey Dobriyan [ref]
    Cc: Christoph Lameter [ref]
    Cc: Pekka Enberg [ref]
    Cc: David Rientjes [ref]
    Cc: Joonsoo Kim [ref]
    Signed-off-by: Andrew Morton [ref]
    Signed-off-by: Linus Torvalds [ref]

```