# Re: \[dm-devel\] \[PATCH 19/32\] block: add helper to get data dir from op

- From: Christoph Hellwig \<hidden\>
- Date: 2015-11-07 10:19:32 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2015/11/102096
- Thread: https://ratatoskr.run/dm-devel/2015/11/102096/t.md

```text
On Thu, Nov 05, 2015 at 11:34:07AM -0600, Mike Christie wrote:
> I can do that. You are right in how they are used. I just did the above,
> to follow the other *_data_dir calls.

I think the *_data_dir calls are horrible interfaces.  But your series
already is huge, so if it makes your life easier I'd say keep it as-is
for now.  But in the long run we should have the interfaces that Bart
suggested, and one that gives you a dma_data_direction from a request,
as that's what a lot of the driver ultimatively want.
```