# Re: \[dm-devel\] \[PATCH\] block: add a bi\_error field to struct bio

- From: Martin K. Petersen \<hidden\>
- Date: 2015-06-04 09:53:43 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2015/06/6629800
- Thread: https://ratatoskr.run/linux-raid/2015/06/6629800/t.md

```text
>>>>> "Christoph" == Christoph Hellwig [ref] writes:

Christoph> The first one has the drawback of only communicating a single
Christoph> possible error (-EIO), and the second one has the drawback of
Christoph> not beeing persistent when bios are queued up, and are not
Christoph> passed along from child to parent bio in the ever more
Christoph> popular chaining scenario.

Christoph> So add a new bi_error field to store an errno value directly
Christoph> in struct bio and remove the existing mechanisms to clean all
Christoph> this up.

Having the error status separate from the bio has been a major headache.
I am entirely in favor of this patch.

It was a big chunk of changes to read through but I did not spot any
obvious problems or polarity reversals. It would be nice to get the
respective fs/md/target driver folks to check their portions, though.

Reviewed-by: Martin K. Petersen <redacted>

-- 
Martin K. Petersen	Oracle Linux Engineering
```