Fix apparent cut-and-paste error in super_90_validate

Subsystems: software raid (multiple disks) support, the rest

2 messages, 2 authors, 2013-08-20 · open the first message on its own page

Fix apparent cut-and-paste error in super_90_validate

From: Dave Jones <hidden>
Date: 2013-08-20 02:26:43 

Setting a variable to itself probably wasn't the intention here.

Signed-off-by: Dave Jones <redacted>

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 9f13e13..b9cb9e4 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -1180,7 +1180,7 @@ static int super_90_validate(struct mddev *mddev, struct md_rdev *rdev)
 			mddev->bitmap_info.offset =
 				mddev->bitmap_info.default_offset;
 			mddev->bitmap_info.space =
-				mddev->bitmap_info.space;
+				mddev->bitmap_info.default_space;
 		}
 
 	} else if (mddev->pers == NULL) {

Re: Fix apparent cut-and-paste error in super_90_validate

From: NeilBrown <hidden>
Date: 2013-08-20 02:46:53 

On Mon, 19 Aug 2013 22:26:32 -0400 Dave Jones [off-list ref] wrote:

Setting a variable to itself probably wasn't the intention here.
Probably not, no.

Applied, thanks.

NeilBrown
quoted hunk
Signed-off-by: Dave Jones <redacted>

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 9f13e13..b9cb9e4 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -1180,7 +1180,7 @@ static int super_90_validate(struct mddev *mddev, struct md_rdev *rdev)
 			mddev->bitmap_info.offset =
 				mddev->bitmap_info.default_offset;
 			mddev->bitmap_info.space =
-				mddev->bitmap_info.space;
+				mddev->bitmap_info.default_space;
 		}
 
 	} else if (mddev->pers == NULL) {




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help