# Re: \[PATCH 0/2\] Modify read error handle for RAID-4,5,6.

- From: NeilBrown \<hidden\>
- Date: 2012-06-27 04:32:28 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2012/06/6620748
- Thread: https://ratatoskr.run/linux-raid/2012/05/6620310/t.md

```text
On Sat, 26 May 2012 10:52:50 +0800 "majianpeng" [ref] wrote:

> When RAID-4,5,6 degraded and met read-error, it will eject the rdev.And then
> the RAID will fail and lost data.Because the function of set-badsector,when 
> this occur,it will set-badsector,not ejecting the rdev.
> When RAID-4,5,6 met read-error, it will re-write if RAID was not degrade.But if 
> re-write error,it will eject the rdev and RAID will degrade and it will take too
> long time for recoverying.So I add judgement for controling how may re-write-error
> can eject the rdev.
> 
> I do those for flexible controling the read-error for different situation.
> 	

Thanks.

> 
> majianpeng (2):
>   md/raid456: When readed error and raid was degraded,it try to
>     set badsector, not ejecting the rdev.

I've applied this one.  I also added 'set_bad = 1' in the case where
the re-write failed.

>   md/raid456:Add interface for contorling eject rdev when re-write
>     failed.

I haven't applied this.  I'm not entirely sure what the point of counting
the errors was, but I don't think it is necessary.

Thanks,
NeilBrown


> 
>  drivers/md/md.c    |   35 +++++++++++++++++++++++++++++++++++
>  drivers/md/md.h    |    2 ++
>  drivers/md/raid5.c |   28 +++++++++++++++++++---------
>  3 files changed, 56 insertions(+), 9 deletions(-)
> 

```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-raid/2012/06/6620748/attachment/0) (application/pgp-signature, 828 bytes)
