# \[PATCH\] avoid double-free upon "old buggy kernel" sysfs\_read failure

- From: Jim Meyering \<hidden\>
- Date: 2012-02-21 11:37:00 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2012/02/6619053
- Thread: https://ratatoskr.run/linux-raid/2012/02/6619053/t.md

```text

* Incremental.c (Incremental): On sysfs_read failure, don't call
sysfs_free(sra) just before "goto out_unlock", since that very
same "sra" is freed the same way by the clean-up code below.
---
FYI, coverity spotted the double free.

 Incremental.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/Incremental.c b/Incremental.c
index 78c9712..4ab9747 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -326,7 +326,6 @@ int Incremental(char *devname, int verbose, int runstop,
 			fprintf(stderr, Name
 		      ": You have an old buggy kernel which cannot support\n"
 				"      --incremental reliably.  Aborting.\n");
-			sysfs_free(sra);
 			rv = 2;
 			goto out_unlock;
 		}
--
1.7.9.1.266.g24ee9
```
