[patch] md/raid10: double lock typo in handle_read_error()

Subsystems: software raid (multiple disks) support, the rest

STALE5524d

2 messages, 2 authors, 2011-07-27 · open the first message on its own page

[patch] md/raid10: double lock typo in handle_read_error()

From: Dan Carpenter <hidden>
Date: 2011-07-27 09:52:02 

This should be a spin_unlock_irq() instead of spin_lock_irq()

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 9214e08..8b29cd4 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2117,7 +2117,7 @@ read_more:
 			mbio->bi_phys_segments = 2;
 		else
 			mbio->bi_phys_segments++;
-		spin_lock_irq(&conf->device_lock);
+		spin_unlock_irq(&conf->device_lock);
 		generic_make_request(bio);
 		bio = NULL;

Re: [patch] md/raid10: double lock typo in handle_read_error()

From: NeilBrown <hidden>
Date: 2011-07-27 10:59:54 

On Wed, 27 Jul 2011 12:52:02 +0300 Dan Carpenter [off-list ref] wrote:
quoted hunk
This should be a spin_unlock_irq() instead of spin_lock_irq()

Signed-off-by: Dan Carpenter <redacted>

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 9214e08..8b29cd4 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2117,7 +2117,7 @@ read_more:
 			mbio->bi_phys_segments = 2;
 		else
 			mbio->bi_phys_segments++;
-		spin_lock_irq(&conf->device_lock);
+		spin_unlock_irq(&conf->device_lock);
 		generic_make_request(bio);
 		bio = NULL;
 
Thanks!
I haven't yet submitted the patch which introduced that bug, so I just fixed
the patch directly and credited you.

Thanks,
NeilBrown
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help