# Re: \[PATCH 1/5\] block: make \_\_blk\_rq\_prep\_clone() copy most command flags

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2010-09-01 15:30:27 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2010/09/45515
- Thread: https://ratatoskr.run/linux-fsdevel/2010/08/45408/t.md

```text
On Mon, Aug 30, 2010 at 11:58:12AM +0200, Tejun Heo wrote:
> Currently __blk_rq_prep_clone() copies only REQ_WRITE and REQ_DISCARD.
> There's no reason to omit other command flags and REQ_FUA needs to be
> copied to implement FUA support in request-based dm.
> 
> REQ_COMMON_MASK which specifies flags to be copied from bio to request
> already identifies all the command flags.  Define REQ_CLONE_MASK to be
> the same as REQ_COMMON_MASK for clarity and make __blk_rq_prep_clone()
> copy all flags in the mask.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>
```
