# Re: \[PATCH v2\] SCSI: fix bio.bi\_rw handling

- From: Jeff Moyer \<hidden\>
- Date: 2010-08-12 13:30:57 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2010/08/3604784
- Thread: https://ratatoskr.run/linux-raid/2010/08/3604784/t.md

```text
Jiri Slaby [ref] writes:

> Return of the bi_rw tests is no longer bool after commit 74450be1. So
> testing against constants doesn't make sense anymore. Fix this bug in
> osd_req_read by removing "== 1" in test.
>
> This is not a problem now, where REQ_WRITE is 1, but this can change
> in the future and we don't want to rely on that.
>
> Signed-off-by: Jiri Slaby <redacted>
> Cc: "James E.J. Bottomley" <redacted>
> Cc: Christoph Hellwig <hch@lst.de>

Reviewed-by: Jeff Moyer <redacted>
```
