# Re: \[PATCH 4/4\] md: Enable takeover for external metadata

- From: Neil Brown \<hidden\>
- Date: 2010-02-10 05:57:10 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2010/02/6609549
- Thread: https://ratatoskr.run/linux-raid/2010/01/6609348/t.md

```text
On Wed, 3 Feb 2010 12:29:53 +0000
"Trela, Maciej" [ref] wrote:

> 
> This is one more patch for md takeover that was accidentally skipped while sending...
> Please, apply it together with the rest of md takeover patches.
> 
> Now md will notify mdmon about the level change.
> Also sysfs redundancy_group specific to non-raid0 is now handled when switching personalities.
> 


Thanks for these.

You should get into the habit of checking your patches
with ./scripts/checkpatch.pl.  There was lots of stray white space and
various other issues.  I have fixed them.  You can find the current patches
in my "md-scatch" branch:
  http://neil.brown.name/git?p=md;a=shortlog;h=refs/heads/md-scratch

I also fixed some other little issues like the fact that you don't want to
set ->delta_disks when converting between RAID0 and RAID5.

I think there are still some issues with error handling if kzalloc fails
while allocating the new 'private' structures.   I'll have another run
through the patches in a few days and see what else I can fix it.

I seem to have misplaced the mdadm patches.  If you would like to send those
again I will have a look and possibly apply them.

Thanks,
NeilBrown
```
