Subject: [PATCH 005/009]: raid0: chunk size check in raid0_run

From: raz ben yehuda <hidden>
Date: 2009-05-19 16:07:34
Subsystem: software raid (multiple disks) support, the rest · Maintainers: Song Liu, Yu Kuai, Linus Torvalds

have raid0 check chunk size in run method instead of in md
hardsect is short and chunksize am int, so i can use %.
 raid0.c |   12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Signed-off-by: raziebe@gmail.com
---
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index a994169..b92b332 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -236,7 +236,17 @@ static int create_strip_zones(mddev_t *mddev)
 	mddev->queue->unplug_fn = raid0_unplug;
 	mddev->queue->backing_dev_info.congested_fn = raid0_congested;
 	mddev->queue->backing_dev_info.congested_data = mddev;
-
+	/*
+	* now since we have the hard sector sizes, we can make sure
+	* chunk size is a multiple of that sector size
+	* note! mdadm enforced 1K minimum for the chunk size.
+	*/
+	if (mddev->chunk_size % mddev->queue->hardsect_size) {
+		printk(KERN_ERR "%s chunk_size of %d not valid\n",
+				mdname(mddev),
+				mddev->chunk_size);
+		goto abort;
+	}
 	printk(KERN_INFO "raid0: done.\n");
 	mddev->private = conf;
 	return 0;

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help