# \[PATCH\] md: Fix for raid6 reshape.

- List: linux-raid
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-raid/2007/03/926868/t

## \[PATCH\] md: Fix for raid6 reshape.

- From: NeilBrown \<hidden\>
- Date: 2007-03-02 04:58:03 
- Message: https://ratatoskr.run/linux-raid/2007/03/926868.md

```text
### Comments for Changeset

Recent patch for raid6 reshape had a change missing that showed up in
subsequent review.

Many places in the raid5 code used "conf->raid_disks-1" to mean
"number of data disks".  With raid6 that had to be changed to
"conf->raid_disk - conf->max_degraded" or similar.  One place was missed.

This bug means that if a raid6 reshape were aborted in the middle the
recorded position would be wrong.  On restart it would either fail (as
the position wasn't on an appropriate boundary) or would leave a section
of the array unreshaped, causing data corruption.


Signed-off-by: Neil Brown <redacted>

### Diffstat output
 ./drivers/md/raid5.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff .prev/drivers/md/raid5.c ./drivers/md/raid5.c
--- .prev/drivers/md/raid5.c	2007-03-02 15:47:51.000000000 +1100
+++ ./drivers/md/raid5.c	2007-03-02 15:48:35.000000000 +1100
@@ -3071,7 +3071,7 @@ static sector_t reshape_request(mddev_t 
 		release_stripe(sh);
 	}
 	spin_lock_irq(&conf->device_lock);
-	conf->expand_progress = (sector_nr + i)*(conf->raid_disks-1);
+	conf->expand_progress = (sector_nr + i) * new_data_disks);
 	spin_unlock_irq(&conf->device_lock);
 	/* Ok, those stripe are ready. We can start scheduling
 	 * reads on the source stripes.
```

## Re: \[PATCH\] md: Fix for raid6 reshape.

- From: Andrew Morton \<akpm@linux-foundation.org\>
- Date: 2007-03-02 06:36:24 
- Message: https://ratatoskr.run/linux-raid/2007/03/926896.md

```text
On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown [ref] wrote:

> -	conf->expand_progress = (sector_nr + i)*(conf->raid_disks-1);
> +	conf->expand_progress = (sector_nr + i) * new_data_disks);

ahem.
```
