# Re: \[PATCH 002 of 4\] md: Make 'repair' actually work for raid1.

- From: Neil Brown \<hidden\>
- Date: 2007-01-24 07:27:50 
- List: linux-raid
- Page: https://ratatoskr.run/linux-raid/2007/01/913794
- Thread: https://ratatoskr.run/linux-raid/2007/01/913794/t.md

```text
On Tuesday January 23, akpm@osdl.org wrote:
> On Tue, 23 Jan 2007 11:26:52 +1100
> NeilBrown [ref] wrote:
> 
> > +					for (j = 0; j < vcnt ; j++)
> > +						memcpy(page_address(sbio->bi_io_vec[j].bv_page),
> > +						       page_address(pbio->bi_io_vec[j].bv_page),
> > +						       PAGE_SIZE);
> 
> I trust these BIOs are known to only contain suitably-allocated, MD-private
> pages?  Because if these pages can be user pages then this change is
> spectacularly buggy ;)

Your trust is well placed.
This is in the 'resync' path, were all buffers are allocated in lowmem
and are full pages and so-forth, so this is perfectly safe.

NeilBrown
```
