DORMANTno replies

[PATCH -next 2/2] cpuidle: add put_device() after of_find_device_by_node()

From: Yang Li <hidden>
Date: 2021-12-10 04:30:35
Also in: linux-arm-msm, lkml
Subsystem: arm/qualcomm mailing list, cpu idle time management framework, the rest · Maintainers: "Rafael J. Wysocki", Daniel Lezcano, Linus Torvalds

This was found by coccicheck:
./drivers/cpuidle/cpuidle-qcom-spm.c:129:1-7: ERROR: missing put_device;
call of_find_device_by_node on line 103, but without a corresponding
object release within this function.

Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---
 drivers/cpuidle/cpuidle-qcom-spm.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/cpuidle/cpuidle-qcom-spm.c b/drivers/cpuidle/cpuidle-qcom-spm.c
index 01e77913a414..3952ea600122 100644
--- a/drivers/cpuidle/cpuidle-qcom-spm.c
+++ b/drivers/cpuidle/cpuidle-qcom-spm.c
@@ -111,6 +111,7 @@ static int spm_cpuidle_register(struct device *cpuidle_dev, int cpu)
 		return -ENOMEM;
 
 	data->spm = dev_get_drvdata(&pdev->dev);
+	put_device(&pdev->dev);
 	if (!data->spm)
 		return -EINVAL;
 
-- 
2.20.1.7.g153144c
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help