# Re: \[PATCH v2 2/5\] thermal: cpufreq\_cooling: Use new thermal pressure update function

- From: Lukasz Luba \<lukasz.luba@arm.com\>
- Date: 2021-10-27 09:00:48 
- List: linux-pm
- Page: https://ratatoskr.run/linux-pm/2021/10/1555441
- Thread: https://ratatoskr.run/linux-pm/2021/10/1543491/t.md

```text


On 10/26/21 5:51 PM, Dietmar Eggemann wrote:
> On 15/10/2021 16:45, Lukasz Luba wrote:
>
> [...]
>
>> @@ -479,10 +478,7 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
>>   	if (ret >= 0) {
>>   		cpufreq_cdev->cpufreq_state = state;
>>   		cpus = cpufreq_cdev->policy->related_cpus;
>> -		max_capacity = arch_scale_cpu_capacity(cpumask_first(cpus));
>> -		capacity = frequency * max_capacity;
>> -		capacity /= cpufreq_cdev->policy->cpuinfo.max_freq;
>
> Took me a while to realize that `cpufreq_cdev->policy->cpuinfo.max_freq`
> is 1000 * per_cpu(freq_factor, cpu), the latter being used now in
> arch_thermal_pressure_update(). Maybe worth mentioning in the patch header?
>

OK, I will put that information into the patch description in the next
version.
```
