# Re: \[PATCH v6\] power: suspend: Move dpm\_watchdog to suspend.c and enhance it

- From: Greg Kroah-Hartman \<gregkh@linuxfoundation.org\>
- Date: 2021-03-23 14:09:53 
- List: linux-pm
- Page: https://ratatoskr.run/linux-pm/2021/03/6312347
- Thread: https://ratatoskr.run/linux-pm/2021/01/6250685/t.md

```text
On Thu, Jan 28, 2021 at 05:39:27PM +0800, Joseph Jang wrote:
> Since dpm_watchdog just cover two functions __device_suspend() and
> device_resume(), we proposed to move it to core power suspend.c to extend
> its coverage and monitor more devices suspend hand issues.
> 
> We propose to use new name suspend watchdog and new timeout handler to
> cover more sleep hang issues. The new timeout handler will dump disk
> sleep task call trace at first round timeout and trigger kernel panic
> at second round timeout.
> The default timer for each round is defined in
> CONFIG_PM_SUSPEND_WATCHDOG_TIMEOUT.
> 
> Signed-off-by: Joseph Jang <redacted>

Seems sane, but I'm not the maintainer of this stuff:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
