Re: [PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs
From: Pali Rohár <pali@kernel.org>
Date: 2021-02-23 14:54:27
Also in:
lkml
From: Pali Rohár <pali@kernel.org>
Date: 2021-02-23 14:54:27
Also in:
lkml
On Tuesday 23 February 2021 15:49:46 Andreas Kemnade wrote:
On Tue, 23 Feb 2021 15:11:20 +0100 Matthias Schiffer [off-list ref] wrote:quoted
Commit cd060b4d0868 ("power: supply: bq27xxx: fix polarity of current_now") changed the sign of current_now for all bq27xxx variants, but on BQ28Z610 I'm now seeing negated values *with* that patch. The GTA04/Openmoko device that was used for testing uses a BQ27000 or BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect. Revert the behaviour for newer ICs. Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" Signed-off-by: Matthias Schiffer <redacted> --- @Andreas Kemnade: It would be great to get a confirmation that the Openmoko battery indeed uses BQ27000/BQ27010 - I was having some trouble finding that information.I can confirm that. here is the corresponding schematic: http://people.openmoko.org/tony_tu/GTA02/hardware/GTA02/CT-GTA02.pdf Regards, Andreas
Nokia N900 has BQ27200 connected via i2c. CCing Maemo mailing list maemo-leste@lists.dyne.org