From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Changes since v3:
- remove the redundant line depends on ARM || ARM64 || COMPILE_TEST
since the whole Kconfig.arm file depends on ARM || ARM64.
- renaming from mtk-cpufreq.c to mediatek-cpufreq.c avoiding
collide and cause confusion at some point in time.
Changes since v2:
- correct the typo in the binding document
Changes since v1:
- drop those patches already accepted
- refine the commit messages and Kconfig dependency
- Kconfig menu entry and file name itself are updated with more
generic name to drop "MT8173" since this driver actually supports
all MediaTek SoCs.
- generate patchset again with git format-patch -C -M --thread=shallow
- fix binding examples by replacing '@' with '-' as the OPP nodes will
never have a "reg" property.
Hi,
The purpose of the series is
- (patch 1 to 3) to fix up current Mediatek cpufreq driver
can't work with the latest tree since one required CPU clock muxer missing
would cause the driver getting the resource fails when driver probe gets
called.
- (patch 4) to enable cpufreq feature on MT2701/MT7623 platform.
- (patch 5 to 6) to update the binding document to reflect
latest driver logic and add more examples guiding people how to apply for
Mediatek cpufreq driver.
Sean Wang (3):
cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC
dt-bindings: cpufreq: move MediaTek cpufreq dt-bindings document to
proper place
dt-bindings: cpufreq: enhance MediaTek cpufreq dt-binding document
.../devicetree/bindings/clock/mt8173-cpu-dvfs.txt | 83 -------
.../bindings/cpufreq/cpufreq-mediatek.txt | 247 +++++++++++++++++++++
drivers/cpufreq/Kconfig.arm | 7 +-
drivers/cpufreq/Makefile | 2 +-
.../{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 +
5 files changed, 253 insertions(+), 88 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/mt8173-cpu-dvfs.txt
create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%)
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang@mediatek.com>
MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with
single cluster and this hardware is also compatible with the existing
driver through enabling CPU frequency feature with operating-points-v2
bindings. Also, this driver actually supports all MediaTek SoCs, the
Kconfig menu entry and file name itself should be updated with more
generic name to drop "MT8173"
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Jean Delvare <redacted>
---
drivers/cpufreq/Kconfig.arm | 7 +++----
drivers/cpufreq/Makefile | 2 +-
drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 ++
3 files changed, 6 insertions(+), 5 deletions(-)
rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%)
diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.csimilarity index 99%rename from drivers/cpufreq/mt8173-cpufreq.crename to drivers/cpufreq/mediatek-cpufreq.cindex fd1886f..481ec77 100644--- a/drivers/cpufreq/mt8173-cpufreq.c+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -575,6 +575,8 @@ static struct platform_driver mt8173_cpufreq_platdrv = {/* List of machines supported by this driver */staticconststructof_device_idmt8173_cpufreq_machines[]__initconst={+{.compatible="mediatek,mt2701",},+{.compatible="mediatek,mt7623",},{.compatible="mediatek,mt817x",},{.compatible="mediatek,mt8173",},{.compatible="mediatek,mt8176",},
From: Eddie Huang <eddie.huang@mediatek.com> Date: 2017-07-11 02:49:53
Hi Sean,
On Mon, 2017-07-10 at 22:23 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with
single cluster and this hardware is also compatible with the existing
driver through enabling CPU frequency feature with operating-points-v2
bindings. Also, this driver actually supports all MediaTek SoCs, the
Kconfig menu entry and file name itself should be updated with more
generic name to drop "MT8173"
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Acked-by: Viresh Kumar <redacted>
Reviewed-by: Jean Delvare <redacted>
---
drivers/cpufreq/Kconfig.arm | 7 +++----
drivers/cpufreq/Makefile | 2 +-
drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 ++
3 files changed, 6 insertions(+), 5 deletions(-)
rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%)
As Viresh mentioned, there are already many drivers use "mtk" as
filename prefix or postfix.To align with those files, I suggest use
mtk-cpufreq.c.I think there are not too many values to change all "mtk-"
to "mediatek-", but it is worth to have the same naming rule for
mediatek upstream driver.
Regards,
Eddie.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Eddie,
On 07/11/2017 04:49 AM, Eddie Huang wrote:
Hi Sean,
On Mon, 2017-07-10 at 22:23 +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with
single cluster and this hardware is also compatible with the existing
driver through enabling CPU frequency feature with operating-points-v2
bindings. Also, this driver actually supports all MediaTek SoCs, the
Kconfig menu entry and file name itself should be updated with more
generic name to drop "MT8173"
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Jean Delvare <redacted>
---
drivers/cpufreq/Kconfig.arm | 7 +++----
drivers/cpufreq/Makefile | 2 +-
drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 ++
3 files changed, 6 insertions(+), 5 deletions(-)
rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%)
As Viresh mentioned, there are already many drivers use "mtk" as
filename prefix or postfix.To align with those files, I suggest use
mtk-cpufreq.c.I think there are not too many values to change all "mtk-"
to "mediatek-", but it is worth to have the same naming rule for
mediatek upstream driver.
In the last submission Jean proposed to change all file names from
mtk-*.[ch] to mediatek-*.[ch] as this will cause less confusion.
Viresh are you OK with that approach or do you prefer that we stay with
mtk prefix? I think it makes sense to have a unique prefix and resolve
the situation we now have with source files and Kconfig options.
But TBH I have no strong feeling for any of the two prefixes.
Regards,
Matthias
Hi Eddie,
On 07/11/2017 04:49 AM, Eddie Huang wrote:
quoted
Hi Sean,
On Mon, 2017-07-10 at 22:23 +0800, sean.wang@mediatek.com wrote:
quoted
From: Sean Wang <sean.wang@mediatek.com>
MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with
single cluster and this hardware is also compatible with the existing
driver through enabling CPU frequency feature with operating-points-v2
bindings. Also, this driver actually supports all MediaTek SoCs, the
Kconfig menu entry and file name itself should be updated with more
generic name to drop "MT8173"
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Jean Delvare <redacted>
---
drivers/cpufreq/Kconfig.arm | 7 +++----
drivers/cpufreq/Makefile | 2 +-
drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 ++
3 files changed, 6 insertions(+), 5 deletions(-)
rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%)
As Viresh mentioned, there are already many drivers use "mtk" as
Do you have a link to when I mentioned this?
/me suffering from Amnesia ? :)
quoted
filename prefix or postfix.To align with those files, I suggest use
mtk-cpufreq.c.I think there are not too many values to change all "mtk-"
to "mediatek-", but it is worth to have the same naming rule for
mediatek upstream driver.
In the last submission Jean proposed to change all file names from
mtk-*.[ch] to mediatek-*.[ch] as this will cause less confusion.
Viresh are you OK with that approach or do you prefer that we stay with mtk
prefix? I think it makes sense to have a unique prefix and resolve the
situation we now have with source files and Kconfig options.
But TBH I have no strong feeling for any of the two prefixes.
I am fine with both. Maybe don't resend for just that, mediatek
doesn't sound any bad.
--
viresh
From: Eddie Huang <eddie.huang@mediatek.com> Date: 2017-07-13 03:54:50
On Thu, 2017-07-13 at 08:46 +0530, Viresh Kumar wrote:
On 12-07-17, 16:50, Matthias Brugger wrote:
quoted
Hi Eddie,
On 07/11/2017 04:49 AM, Eddie Huang wrote:
quoted
Hi Sean,
On Mon, 2017-07-10 at 22:23 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
quoted
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with
single cluster and this hardware is also compatible with the existing
driver through enabling CPU frequency feature with operating-points-v2
bindings. Also, this driver actually supports all MediaTek SoCs, the
Kconfig menu entry and file name itself should be updated with more
generic name to drop "MT8173"
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Acked-by: Viresh Kumar <redacted>
Reviewed-by: Jean Delvare <redacted>
---
drivers/cpufreq/Kconfig.arm | 7 +++----
drivers/cpufreq/Makefile | 2 +-
drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 ++
3 files changed, 6 insertions(+), 5 deletions(-)
rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%)
As Viresh mentioned, there are already many drivers use "mtk" as
Do you have a link to when I mentioned this?
/me suffering from Amnesia ? :)
filename prefix or postfix.To align with those files, I suggest use
mtk-cpufreq.c.I think there are not too many values to change all "mtk-"
to "mediatek-", but it is worth to have the same naming rule for
mediatek upstream driver.
In the last submission Jean proposed to change all file names from
mtk-*.[ch] to mediatek-*.[ch] as this will cause less confusion.
Viresh are you OK with that approach or do you prefer that we stay with mtk
prefix? I think it makes sense to have a unique prefix and resolve the
situation we now have with source files and Kconfig options.
But TBH I have no strong feeling for any of the two prefixes.
I am fine with both. Maybe don't resend for just that, mediatek
doesn't sound any bad.
I am also fine with both. I think most people won't confuse about mtk
and mediatek. I don't like send patches to just only change filenames
and kconfig, especially kconfig modification will affect project
defconfigs. My point is we shouldn't spend much time on this topic, and
revisit filename when that driver need support new SoC, like this case.
Regards,
Eddie
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jean Delvare <hidden> Date: 2017-07-17 08:05:57
On Thu, 13 Jul 2017 11:54:38 +0800, Eddie Huang wrote:
On Thu, 2017-07-13 at 08:46 +0530, Viresh Kumar wrote:
quoted
I am fine with both. Maybe don't resend for just that, mediatek
doesn't sound any bad.
I am also fine with both. I think most people won't confuse about mtk
and mediatek. I don't like send patches to just only change filenames
and kconfig, especially kconfig modification will affect project
defconfigs. My point is we shouldn't spend much time on this topic, and
revisit filename when that driver need support new SoC, like this case.
I believe that being consistent is important, and I believe that
3-letter abbreviations are confusing. So in my ideal fantasy world, all
these drivers would be named *mediatek* and their config options would
be CONFIG_*MEDIATEK*. That being said, it's only my general opinion on
the topic. I'm not going to send any patch to rename any of these
drivers, as I have many tasks of higher priority on my own plate. And I
agree that renaming existing drivers does have a cost as well. So
whatever is decided is fine with me, really.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jean Delvare <hidden> Date: 2017-07-17 08:07:05
On Mon, 10 Jul 2017 22:23:08 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with
single cluster and this hardware is also compatible with the existing
driver through enabling CPU frequency feature with operating-points-v2
bindings. Also, this driver actually supports all MediaTek SoCs, the
Kconfig menu entry and file name itself should be updated with more
generic name to drop "MT8173"
Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Acked-by: Viresh Kumar <redacted>
Reviewed-by: Jean Delvare <redacted>
Confirmed, looks good to me.
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sean Wang <sean.wang@mediatek.com>
Update binding document with adding operating-points-v2 as the required
property and the cooling level as the optional properties and adding more
examples guiding people how to use MediaTek cpufreq driver for MediaTek
SoCs.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
.../bindings/cpufreq/cpufreq-mediatek.txt | 170 ++++++++++++++++++++-
1 file changed, 167 insertions(+), 3 deletions(-)
@@ -1,4 +1,5 @@-Device Tree Clock bindins for CPU DVFS of Mediatek MT8173 SoC+Binding for MediaTek's CPUFreq driver+===================================== Required properties: - clocks: A list of phandle + clock-specifier pairs for the clocks listed in clock names.
@@ -9,6 +10,8 @@ Required properties: transition and not stable yet. Please refer to Documentation/devicetree/bindings/clk/clock-bindings.txt for generic clock consumer properties.+- operating-points-v2: Please refer to Documentation/devicetree/bindings/opp/opp.txt+ for detail. - proc-supply: Regulator for Vproc of CPU cluster. Optional properties:
From: Sean Wang <sean.wang@mediatek.com>
The old place is Documentation/devicetree/bindings/clock/ that would
let people hard to find how to use MediaTek cpufreq driver, so moving
it to the appropriate place as other cpufreq drivers done would be
better.
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
.../bindings/{clock/mt8173-cpu-dvfs.txt => cpufreq/cpufreq-mediatek.txt} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename Documentation/devicetree/bindings/{clock/mt8173-cpu-dvfs.txt => cpufreq/cpufreq-mediatek.txt} (100%)
diff --git a/Documentation/devicetree/bindings/clock/mt8173-cpu-dvfs.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txtsimilarity index 100%rename from Documentation/devicetree/bindings/clock/mt8173-cpu-dvfs.txtrename to Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
--
2.7.4
From: Sean Wang <sean.wang@mediatek.com> Date: 2017-07-17 06:16:42
Hi, Viresh
I missed to add Acks from Rob for patch 2 and 3 since we sent out almost
at the same time. Do I need to resend again for this or the series is
okay for you?
Sean
On Mon, 2017-07-10 at 22:23 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Changes since v3:
- remove the redundant line depends on ARM || ARM64 || COMPILE_TEST
since the whole Kconfig.arm file depends on ARM || ARM64.
- renaming from mtk-cpufreq.c to mediatek-cpufreq.c avoiding
collide and cause confusion at some point in time.
Changes since v2:
- correct the typo in the binding document
Changes since v1:
- drop those patches already accepted
- refine the commit messages and Kconfig dependency
- Kconfig menu entry and file name itself are updated with more
generic name to drop "MT8173" since this driver actually supports
all MediaTek SoCs.
- generate patchset again with git format-patch -C -M --thread=shallow
- fix binding examples by replacing '@' with '-' as the OPP nodes will
never have a "reg" property.
Hi,
The purpose of the series is
- (patch 1 to 3) to fix up current Mediatek cpufreq driver
can't work with the latest tree since one required CPU clock muxer missing
would cause the driver getting the resource fails when driver probe gets
called.
- (patch 4) to enable cpufreq feature on MT2701/MT7623 platform.
- (patch 5 to 6) to update the binding document to reflect
latest driver logic and add more examples guiding people how to apply for
Mediatek cpufreq driver.
Sean Wang (3):
cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC
dt-bindings: cpufreq: move MediaTek cpufreq dt-bindings document to
proper place
dt-bindings: cpufreq: enhance MediaTek cpufreq dt-binding document
.../devicetree/bindings/clock/mt8173-cpu-dvfs.txt | 83 -------
.../bindings/cpufreq/cpufreq-mediatek.txt | 247 +++++++++++++++++++++
drivers/cpufreq/Kconfig.arm | 7 +-
drivers/cpufreq/Makefile | 2 +-
.../{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 +
5 files changed, 253 insertions(+), 88 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/mt8173-cpu-dvfs.txt
create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Viresh
I missed to add Acks from Rob for patch 2 and 3 since we sent out almost
at the same time. Do I need to resend again for this or the series is
okay for you?
Looks like you missed including Rafael for this series (He is the one
who applies these patches).
I will let him answer for this.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Rafael J. Wysocki <hidden> Date: 2017-07-17 11:41:02
On Monday, July 17, 2017 01:05:43 PM Viresh Kumar wrote:
On 17-07-17, 14:16, Sean Wang wrote:
quoted
Hi, Viresh
I missed to add Acks from Rob for patch 2 and 3 since we sent out almost
at the same time. Do I need to resend again for this or the series is
okay for you?
Looks like you missed including Rafael for this series (He is the one
who applies these patches).
I will let him answer for this.
Please respin with all of the applicable tags.
I haven't been following all of the discussions on this that closely.
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html