Re: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq
From: Thomas Renninger <hidden>
Date: 2016-10-24 15:11:36
Also in:
lkml
From: Thomas Renninger <hidden>
Date: 2016-10-24 15:11:36
Also in:
lkml
On Thursday, October 20, 2016 01:42:49 PM Shilpasri G Bhat wrote:
On 10/20/2016 04:23 AM, Laura Abbott wrote:quoted
When converting to a shared library in ac5a181d065d ("cpupower: Add cpuidle parts into library"), cpu_freq_cpu_exists was converted to cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success. Check for the correct return value in cpufreq-set. See https://bugzilla.redhat.com/show_bug.cgi?id=1374212 Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library") Reported-by: Julian Seward <redacted> Signed-off-by: Laura Abbott <redacted> --- v2: Drop another redundant cpupower_is_cpu_onlineReviewed-by:Shilpasri G Bhat [off-list ref]
Acked-by: Thomas Renninger <trenn@suse.com>
I wanted to go through all recently sent patches and adjust rebase them to
my lates changes.
But I guess the fact that I push this from day to day because of other
stuff should not hold off such important fixes.
I collect and review all others as well the next day(s)..
Thomas