Thread (7 messages) 7 messages, 2 authors, 2016-05-24

Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition

From: Pali Rohár <hidden>
Date: 2016-05-19 09:13:18
Also in: lkml

On Saturday 09 January 2016 23:42:30 Pali Rohár wrote:
On Friday 01 January 2016 12:26:21 Pali Rohár wrote:
quoted
On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote:
quoted
All calls to isp1704_write() are using parameter sequence of
isp1704_write(isp, reg, val) but the function is defined as
isp1704_write(isp, val, reg). Fix isp1704_write function definition
so that the driver to be functional.

Signed-off-by: Ivaylo Dimitrov <redacted>
Reviewed-by: Pali Rohár <redacted>

This problem is there since inclusion of driver itself. No idea why
that driver could work... I remember that it detected correctly type
of charger.

I will test this patch on real N900 HW in one or two weeks to check
how it behave after patching...
Tested-by: Pali Rohár <redacted>

Please send this patch to all stable kernels.
Hi! I still think that this patch should go to stable kernels. Because
without it driver does not work... Will somebody send it to stable?

-- 
Pali Rohár
pali.rohar@gmail.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help