[pm:pm-cpufreq-test 51/53] drivers/cpufreq/amd_freq_sensitivity.c:85:29: error: dereferencing pointer to incomplete type 'struct od_dbs_tuners'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git pm-cpufreq-test
head:   9783d25b17d3924c29ab265daa0610a232a3ece4
commit: 82171028d648b510e2b01e7983cb95fd46c30fbb [51/53] cpufreq: governor: Relocate definitions of tuners structures
config: i386-allmodconfig (attached as .config)
reproduce:
        git checkout 82171028d648b510e2b01e7983cb95fd46c30fbb
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/cpufreq/amd_freq_sensitivity.c: In function 'amd_powersave_bias_target':
   drivers/cpufreq/amd_freq_sensitivity.c:52:26: error: 'struct dbs_governor' has no member named 'get_cpu_dbs_info_s'
      dbs_governor_of(policy)->get_cpu_dbs_info_s(policy->cpu);
                             ^
   drivers/cpufreq/amd_freq_sensitivity.c:54:14: error: dereferencing pointer to incomplete type 'struct od_cpu_dbs_info_s'
     if (!od_info->freq_table)
                 ^

quoted

drivers/cpufreq/amd_freq_sensitivity.c:85:29: error: dereferencing pointer to incomplete type 'struct od_dbs_tuners'

     if (sensitivity < od_tuners->powersave_bias) {
                                ^

vim +85 drivers/cpufreq/amd_freq_sensitivity.c

9c5320c8 Jacob Shin        2013-04-04  46  	struct msr actual, reference;
9c5320c8 Jacob Shin        2013-04-04  47  	struct cpu_data_t *data = &per_cpu(cpu_data, policy->cpu);
227e492f Rafael J. Wysocki 2016-02-07  48  	struct policy_dbs_info *policy_dbs = policy->governor_data;
227e492f Rafael J. Wysocki 2016-02-07  49  	struct dbs_data *od_data = policy_dbs->dbs_data;
9c5320c8 Jacob Shin        2013-04-04  50  	struct od_dbs_tuners *od_tuners = od_data->tuners;
9c5320c8 Jacob Shin        2013-04-04  51  	struct od_cpu_dbs_info_s *od_info =
de713ff2 Rafael J. Wysocki 2016-02-07 @52  		dbs_governor_of(policy)->get_cpu_dbs_info_s(policy->cpu);
9c5320c8 Jacob Shin        2013-04-04  53  
9c5320c8 Jacob Shin        2013-04-04  54  	if (!od_info->freq_table)
9c5320c8 Jacob Shin        2013-04-04  55  		return freq_next;
9c5320c8 Jacob Shin        2013-04-04  56  
9c5320c8 Jacob Shin        2013-04-04  57  	rdmsr_on_cpu(policy->cpu, MSR_AMD64_FREQ_SENSITIVITY_ACTUAL,
9c5320c8 Jacob Shin        2013-04-04  58  		&actual.l, &actual.h);
9c5320c8 Jacob Shin        2013-04-04  59  	rdmsr_on_cpu(policy->cpu, MSR_AMD64_FREQ_SENSITIVITY_REFERENCE,
9c5320c8 Jacob Shin        2013-04-04  60  		&reference.l, &reference.h);
9c5320c8 Jacob Shin        2013-04-04  61  	actual.h &= 0x00ffffff;
9c5320c8 Jacob Shin        2013-04-04  62  	reference.h &= 0x00ffffff;
9c5320c8 Jacob Shin        2013-04-04  63  
9c5320c8 Jacob Shin        2013-04-04  64  	/* counter wrapped around, so stay on current frequency */
9c5320c8 Jacob Shin        2013-04-04  65  	if (actual.q < data->actual || reference.q < data->reference) {
9c5320c8 Jacob Shin        2013-04-04  66  		freq_next = policy->cur;
9c5320c8 Jacob Shin        2013-04-04  67  		goto out;
9c5320c8 Jacob Shin        2013-04-04  68  	}
9c5320c8 Jacob Shin        2013-04-04  69  
9c5320c8 Jacob Shin        2013-04-04  70  	d_actual = actual.q - data->actual;
9c5320c8 Jacob Shin        2013-04-04  71  	d_reference = reference.q - data->reference;
9c5320c8 Jacob Shin        2013-04-04  72  
9c5320c8 Jacob Shin        2013-04-04  73  	/* divide by 0, so stay on current frequency as well */
9c5320c8 Jacob Shin        2013-04-04  74  	if (d_reference == 0) {
9c5320c8 Jacob Shin        2013-04-04  75  		freq_next = policy->cur;
9c5320c8 Jacob Shin        2013-04-04  76  		goto out;
9c5320c8 Jacob Shin        2013-04-04  77  	}
9c5320c8 Jacob Shin        2013-04-04  78  
9c5320c8 Jacob Shin        2013-04-04  79  	sensitivity = POWERSAVE_BIAS_MAX -
9c5320c8 Jacob Shin        2013-04-04  80  		(POWERSAVE_BIAS_MAX * (d_reference - d_actual) / d_reference);
9c5320c8 Jacob Shin        2013-04-04  81  
9c5320c8 Jacob Shin        2013-04-04  82  	clamp(sensitivity, 0, POWERSAVE_BIAS_MAX);
9c5320c8 Jacob Shin        2013-04-04  83  
9c5320c8 Jacob Shin        2013-04-04  84  	/* this workload is not CPU bound, so choose a lower freq */
9c5320c8 Jacob Shin        2013-04-04 @85  	if (sensitivity < od_tuners->powersave_bias) {
9c5320c8 Jacob Shin        2013-04-04  86  		if (data->freq_prev == policy->cur)
9c5320c8 Jacob Shin        2013-04-04  87  			freq_next = policy->cur;
9c5320c8 Jacob Shin        2013-04-04  88  

:::::: The code at line 85 was first introduced by commit
:::::: 9c5320c8ea8b8423edca2c40cd559f1ce9496dab cpufreq: AMD "frequency sensitivity feedback" powersave bias for ondemand governor

:::::: TO: Jacob Shin [off-list ref]
:::::: CC: Rafael J. Wysocki [off-list ref]

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation