Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering utilization update callbacks
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2016-02-22 10:45:55
Also in:
lkml
On 19-02-16, 23:26, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki <redacted> Subject: [PATCH] cpufreq: Rework the scheduler hooks for triggering updates Commit fe7034338ba0 (cpufreq: Add mechanism for registering utilization update callbacks) added cpufreq_update_util() to be called by the scheduler (from the CFS part) on utilization updates. The goal was to allow CFS to pass utilization information to cpufreq and to trigger it to evaluate the frequency/voltage configuration (P-state) of every CPU on a regular basis. However, the last two arguments of that function are never used by the current code, so CFS might simply call cpufreq_trigger_update() instead of it. For this reason, drop the last two arguments of cpufreq_update_util(), rename it to cpufreq_trigger_update() and modify CFS to call it. Moreover, since the utilization is not involved in that now, rename data types, functions and variables related to cpufreq_trigger_update() to reflect that (eg. struct update_util_data becomes struct freq_update_hook and so on). Signed-off-by: Rafael J. Wysocki <redacted> --- drivers/cpufreq/cpufreq.c | 48 ++++++++++++++++++++++--------------- drivers/cpufreq/cpufreq_governor.c | 27 ++++++++++---------- drivers/cpufreq/cpufreq_governor.h | 2 - drivers/cpufreq/intel_pstate.c | 15 +++++------ include/linux/cpufreq.h | 32 +++--------------------- kernel/sched/deadline.c | 2 - kernel/sched/fair.c | 13 +--------- kernel/sched/rt.c | 2 - 8 files changed, 58 insertions(+), 83 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- viresh