[PATCH] thermal: use %d to print S32 parameters

Subsystems: the rest, thermal

STALE3825d

3 messages, 2 authors, 2016-02-18 · open the first message on its own page

[PATCH] thermal: use %d to print S32 parameters

From: Leo Yan <hidden>
Date: 2016-01-13 08:34:30

Power allocator's parameters are S32 type, so use %d to print them.

Signed-off-by: Leo Yan <redacted>
---
 drivers/thermal/thermal_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index d9e525c..1335df2 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -931,7 +931,7 @@ static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show,
 	struct thermal_zone_device *tz = to_thermal_zone(dev);		\
 									\
 	if (tz->tzp)							\
-		return sprintf(buf, "%u\n", tz->tzp->name);		\
+		return sprintf(buf, "%d\n", tz->tzp->name);		\
 	else								\
 		return -EIO;						\
 	}								\
-- 
1.9.1

Re: [PATCH] thermal: use %d to print S32 parameters

From: Javi Merino <hidden>
Date: 2016-01-13 09:22:25

On Wed, Jan 13, 2016 at 04:33:56PM +0800, Leo Yan wrote:
Power allocator's parameters are S32 type, so use %d to print them.
Indeed.  The name of the macro is create_s32_tzp_attr(), it's
explicitly saying that the parameter is signed!
Signed-off-by: Leo Yan <redacted>
Acked-by: Javi Merino <redacted>

Cheers,
Javi
quoted hunk
---
 drivers/thermal/thermal_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index d9e525c..1335df2 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -931,7 +931,7 @@ static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show,
 	struct thermal_zone_device *tz = to_thermal_zone(dev);		\
 									\
 	if (tz->tzp)							\
-		return sprintf(buf, "%u\n", tz->tzp->name);		\
+		return sprintf(buf, "%d\n", tz->tzp->name);		\
 	else								\
 		return -EIO;						\
 	}								\
-- 
1.9.1

Re: [PATCH] thermal: use %d to print S32 parameters

From: Leo Yan <hidden>
Date: 2016-02-18 09:42:32

On Wed, Jan 13, 2016 at 09:22:16AM +0000, Javi Merino wrote:
On Wed, Jan 13, 2016 at 04:33:56PM +0800, Leo Yan wrote:
quoted
Power allocator's parameters are S32 type, so use %d to print them.
Indeed.  The name of the macro is create_s32_tzp_attr(), it's
explicitly saying that the parameter is signed!
quoted
Signed-off-by: Leo Yan <redacted>
Acked-by: Javi Merino <redacted>
Rui, Eduardo,

Could you help merge this patch as well?

Thanks,
Leo Yan
Cheers,
Javi
quoted
---
 drivers/thermal/thermal_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index d9e525c..1335df2 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -931,7 +931,7 @@ static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show,
 	struct thermal_zone_device *tz = to_thermal_zone(dev);		\
 									\
 	if (tz->tzp)							\
-		return sprintf(buf, "%u\n", tz->tzp->name);		\
+		return sprintf(buf, "%d\n", tz->tzp->name);		\
 	else								\
 		return -EIO;						\
 	}								\
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help