re: power_supply: Add support for TI BQ25890 charger chip
From: Dan Carpenter <hidden>
Date: 2015-05-26 15:34:34
From: Dan Carpenter <hidden>
Date: 2015-05-26 15:34:34
Hello Laurentiu Palcu,
The patch 4aeae9cb0dad: "power_supply: Add support for TI BQ25890
charger chip" from May 19, 2015, leads to the following static
checker warning:
drivers/power/bq25890_charger.c:843 bq25890_probe()
warn: impossible condition '(bq->chip_id < 0) => (0-255 < 0)'
drivers/power/bq25890_charger.c
841
842 bq->chip_id = bq25890_field_read(bq, F_PN);
843 if (bq->chip_id < 0) {
^^^^^^^^^^^^^^^
Never true.
844 dev_err(dev, "Cannot read chip ID.\n");
845 return ret;
846 }
847
regards,
dan carpenter