DORMANTno replies

[PATCH] phy: phy-mtk-dp: drop unused variables

From: Vinod Koul <vkoul@kernel.org>
Date: 2026-09-13 10:54:59
Subsystem: arm/mediatek usb3 phy driver, drm drivers for mediatek, generic phy framework, the rest · Maintainers: Chunfeng Yun, Chun-Kuang Hu, Philipp Zabel, Vinod Koul, Linus Torvalds

Recent changes in driver added unused variables causing build warnings:

drivers/phy/mediatek/phy-mtk-dp.c: In function ‘mtk_dp_phy_set_digital_drv_params’:
drivers/phy/mediatek/phy-mtk-dp.c:332:16: error: unused variable ‘ret’ [-Werror=unused-variable]
  332 |         int i, ret;
      |                ^~~
drivers/phy/mediatek/phy-mtk-dp.c: In function ‘mtk_dp_phy_init’:
drivers/phy/mediatek/phy-mtk-dp.c:348:24: error: unused variable ‘dev’ [-Werror=unused-variable]
  348 |         struct device *dev = &phy->dev;
      |                        ^~~
drivers/phy/mediatek/phy-mtk-dp.c: In function ‘mtk_dp_phy_disable_all_lanes’:
drivers/phy/mediatek/phy-mtk-dp.c:457:13: error: unused variable ‘ret’ [-Werror=unused-variable]
  457 |         int ret;
      |             ^~~

Drop these to fix these

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/phy/mediatek/phy-mtk-dp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy-mtk-dp.c
index 6d06e1c39e3b..7108b16d33a2 100644
--- a/drivers/phy/mediatek/phy-mtk-dp.c
+++ b/drivers/phy/mediatek/phy-mtk-dp.c
@@ -329,7 +329,7 @@ static void mtk_dp_phy_set_digital_drv_params(struct mtk_dp_phy *dp_phy)
 {
 	const struct mtk_dp_phy_pdata *pdata = dp_phy->pdata;
 	const u32 reg = pdata->regs_dig_lane[DP_PHYD_LAN_DRIVING_PARAM_0];
-	int i, ret;
+	int i;
 
 	/*
 	 * Assume that all lanes need the same driving parameters: this
@@ -345,7 +345,6 @@ static void mtk_dp_phy_set_digital_drv_params(struct mtk_dp_phy *dp_phy)
 static int mtk_dp_phy_init(struct phy *phy)
 {
 	struct mtk_dp_phy *dp_phy = phy_get_drvdata(phy);
-	struct device *dev = &phy->dev;
 
 	mtk_dp_phy_set_digital_drv_params(dp_phy);
 	mtk_dp_phy_set_analog_calibration_params(dp_phy);
@@ -454,7 +453,6 @@ static int mtk_dp_phy_disable_all_lanes(struct mtk_dp_phy *dp_phy)
 {
 	const struct mtk_dp_phy_pdata *pdata = dp_phy->pdata;
 	const u8 *regs = pdata->regs_dig_glb;
-	int ret;
 	u32 val;
 
 	/* Get mask of currently enabled lane */
-- 
2.53.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help