# \[PATCH v4 07/13\] phy: qualcomm: qcom-uniphy-pcie-usb3-28lp: Assert reset on clock enable failure - From: George Moussalem via B4 Relay \ - Date: 2026-09-08 09:41:56 - List: linux-phy - Page: https://ratatoskr.run/linux-phy/2026/09/17529793 - Thread: https://ratatoskr.run/linux-arm-msm/2026/09/17529786/t.md ```text From: George Moussalem When the PHY fails the enable clocks, it leaves the PHY out of reset. Fix this by asserting the reset before returning the error. Tested-by: Stanislaw Pal Signed-off-by: George Moussalem --- drivers/phy/qualcomm/phy-qcom-uniphy-pcie-usb3-28lp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-usb3-28lp.c b/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-usb3-28lp.c index 0a50eb44c0ce..15b17044fde3 100644 --- a/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-usb3-28lp.c +++ b/drivers/phy/qualcomm/phy-qcom-uniphy-pcie-usb3-28lp.c @@ -164,6 +164,7 @@ static int qcom_uniphy_pcie_power_on(struct phy *x) ret = clk_bulk_prepare_enable(phy->num_clks, phy->clks); if (ret) { dev_err(phy->dev, "clk prepare and enable failed %d\n", ret); + reset_control_bulk_assert(phy->num_resets, phy->resets); return ret; } -- 2.53.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ```