# Re: \[PATCH v3 11/19\] soc: starfive: Add jh7110-hdmi-subsystem driver

- From: Uwe Kleine-König \<hidden\>
- Date: 2026-09-07 08:23:52 
- List: linux-phy
- Page: https://ratatoskr.run/linux-phy/2026/09/17523510
- Thread: https://ratatoskr.run/linux-phy/2026/09/17514319/t.md

```text
Hello Michael,

On Fri, Sep 04, 2026 at 03:27:12PM +0200, Michal Wilczynski wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>

Please don't add includes for <linux/mod_devicetable.h> as it introduces
many unneeded build dependencies. Either rely on
<linux/platform_device.h> providing of_device_id (IMHO preferred), or
include <linux/device-id/of.h> directly.

The same applies to two more patches in this series.

Best regards
Uwe
```