[PATCH v2] phy: qcom-qmp: remove redundant error of clock bulk

Subsystems: arm/qualcomm mailing list, generic phy framework, the rest

STALE1925d LANDED: 1 (0M)

1 review trailer; landed in mainline as 4bbe33f66d7d on 2021-05-31.

2 messages, 2 authors, 2021-05-31 · open the first message on its own page

[PATCH v2] phy: qcom-qmp: remove redundant error of clock bulk

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: 2021-05-17 05:37:33

There is error log in clk_bulk_prepare/enable()

Reviewed-by: Bjorn Andersson <redacted>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2: add reviewed-by Bjorn
---
 drivers/phy/qualcomm/phy-qcom-qmp.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 7877f70cf86f..882b8ecae235 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -3993,10 +3993,8 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy)
 	}
 
 	ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
-	if (ret) {
-		dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
+	if (ret)
 		goto err_rst;
-	}
 
 	if (cfg->has_phy_dp_com_ctrl) {
 		qphy_setbits(dp_com, QPHY_V3_DP_COM_POWER_DOWN_CTRL,
@@ -4430,10 +4428,8 @@ static int __maybe_unused qcom_qmp_phy_runtime_resume(struct device *dev)
 	}
 
 	ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks);
-	if (ret) {
-		dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret);
+	if (ret)
 		return ret;
-	}
 
 	ret = clk_prepare_enable(qphy->pipe_clk);
 	if (ret) {
-- 
2.18.0
-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH v2] phy: qcom-qmp: remove redundant error of clock bulk

From: Vinod Koul <vkoul@kernel.org>
Date: 2021-05-31 08:21:06

On 17-05-21, 13:37, Chunfeng Yun wrote:
There is error log in clk_bulk_prepare/enable()
Applied, thanks

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help