[PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

Subsystems: hisilicon ptt driver, performance events subsystem, the rest

STALE856d LANDED

Landed in mainline as 0770ceaff2f6 on 2024-06-05.

4 messages, 4 authors, 2024-06-06 · open the first message on its own page

[PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

From: <hidden>
Date: 2024-06-02 00:07:29

From: "Dr. David Alan Gilbert" <redacted>

'hisi_ptt_queue' has been unused since the original
commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
HiSilicon PCIe Trace packet").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <redacted>
---
 tools/perf/util/hisi-ptt.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
index 52d0ce302ca0..37ea987017f6 100644
--- a/tools/perf/util/hisi-ptt.c
+++ b/tools/perf/util/hisi-ptt.c
@@ -35,11 +35,6 @@ struct hisi_ptt {
 	u32 pmu_type;
 };
 
-struct hisi_ptt_queue {
-	struct hisi_ptt *ptt;
-	struct auxtrace_buffer *buffer;
-};
-
 static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
 {
 	uint32_t head = *(uint32_t *)buf;
-- 
2.45.1

Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

From: Jonathan Cameron <hidden>
Date: 2024-06-03 08:31:46

On Sun,  2 Jun 2024 01:07:09 +0100
linux@treblig.org wrote:
From: "Dr. David Alan Gilbert" <redacted>

'hisi_ptt_queue' has been unused since the original
commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
HiSilicon PCIe Trace packet").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <redacted>
LGTM
Minimal
Reviewed-by: Jonathan Cameron <redacted>
by which I mean I searched for it and indeed found only this definition.
quoted hunk
---
 tools/perf/util/hisi-ptt.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
index 52d0ce302ca0..37ea987017f6 100644
--- a/tools/perf/util/hisi-ptt.c
+++ b/tools/perf/util/hisi-ptt.c
@@ -35,11 +35,6 @@ struct hisi_ptt {
 	u32 pmu_type;
 };
 
-struct hisi_ptt_queue {
-	struct hisi_ptt *ptt;
-	struct auxtrace_buffer *buffer;
-};
-
 static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
 {
 	uint32_t head = *(uint32_t *)buf;

Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

From: Ian Rogers <irogers@google.com>
Date: 2024-06-03 16:32:11

On Sat, Jun 1, 2024 at 5:07 PM [off-list ref] wrote:
From: "Dr. David Alan Gilbert" <redacted>

'hisi_ptt_queue' has been unused since the original
commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
HiSilicon PCIe Trace packet").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <redacted>
Hi/thanks David,

Reviewed-by: Ian Rogers <irogers@google.com>

Ian
quoted hunk
---
 tools/perf/util/hisi-ptt.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
index 52d0ce302ca0..37ea987017f6 100644
--- a/tools/perf/util/hisi-ptt.c
+++ b/tools/perf/util/hisi-ptt.c
@@ -35,11 +35,6 @@ struct hisi_ptt {
        u32 pmu_type;
 };

-struct hisi_ptt_queue {
-       struct hisi_ptt *ptt;
-       struct auxtrace_buffer *buffer;
-};
-
 static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
 {
        uint32_t head = *(uint32_t *)buf;
--
2.45.1

Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

From: Namhyung Kim <namhyung@kernel.org>
Date: 2024-06-06 17:11:49

On Sun, 02 Jun 2024 01:07:09 +0100, linux@treblig.org wrote:

Applied to perf-tools-next, thanks!

Best regards,
Namhyung
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help