Re: [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS
From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2021-10-28 11:17:44
Also in:
lkml
Em Thu, Oct 28, 2021 at 09:23:58AM +0100, John Garry escreveu:
On 25/10/2021 17:20, Arnaldo Carvalho de Melo wrote:quoted
Em Mon, Oct 25, 2021 at 01:40:44PM +0200, Jiri Olsa escreveu:quoted
On Fri, Oct 22, 2021 at 10:42:11AM +0100, John Garry wrote:quoted
On 21/10/2021 13:48, Jiri Olsa wrote: ok, so IIRC, then the rule for building .o from .c in tools/build/Makefile.build will pick up HOSTCFLAGS through this variable, so we then don't need to explicitly mention it in the per-target rule, so can have this as before in pmu-events/Build
quoted
quoted
quoted
HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include
quoted
quoted
quoted
right?
quoted
quoted
quoted
(Indeed I guess that we can get rid of -I$(srctree)/tools/include as well)
quoted
quoted
hm, the -I.. should stay no? I don't see that it's being added soem other way
quoted
Probably this change from KBUILD_HOSTCFLAGS back to HOSTCFLAGS should come with this;
quoted
Cc: Laura Abbott <redacted> Cc: Masahiro Yamada <redacted> Fixes: 96f14fe738b69dd9 ("kbuild: Rename HOSTCFLAGS to KBUILD_HOSTCFLAGS")
quoted
Right?
Maybe, but then renaming back from KBUILD_HOSTCFLAGS -> HOSTCFLAGS seems odd as a fix
Anyway, now that this original series is in perf/core,
Nope, just this one landed:
commit 342cb7ebf5e29fff4dc09ab2c8f37d710f8f5206
Author: John Garry [off-list ref]
Date: Thu Oct 21 17:16:44 2021 +0800
perf jevents: Fix some would-be warnings
---
The one you asked to wait for further discussion wasn't merged.
- Arnaldo
I'll send patches on top with this change, cc'ing Laura and Masahiro