Thread (2 messages) 2 messages, 2 authors, 2021-09-09

Re: [PATCH] perf scripts python: fix passing arguments to stackcollapse report

From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2021-09-09 13:21:30

Possibly related (same subject, not in this thread)

Em Mon, Sep 06, 2021 at 04:16:21PM +0200, Michael Petlan escreveu:
Hi Arnaldo, could you merge this?
It seems still valid.
Next time please reply to the original patch, that way b4 will find it
from the Message-ID from your reply message.

I'm digging it from my inboxes, thanks for resending!

- Arnaldo
 
Thank you.
Michael


On Mon, 27 Apr 2020, Michael Petlan wrote:
quoted
The '--' prevented arguments from being passed to the script, such as:

  $ perf script report stackcollapse -i my_perf.data

Signed-off-by: Michael Petlan <redacted>
---
 tools/perf/scripts/python/bin/stackcollapse-report | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/scripts/python/bin/stackcollapse-report b/tools/perf/scripts/python/bin/stackcollapse-report
index 356b9656393d..21a356bd27f6 100755
--- a/tools/perf/scripts/python/bin/stackcollapse-report
+++ b/tools/perf/scripts/python/bin/stackcollapse-report
@@ -1,3 +1,3 @@
 #!/bin/sh
 # description: produce callgraphs in short form for scripting use
-perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py -- "$@"
+perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py "$@"
-- 
2.18.1
-- 

- Arnaldo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help