[PATCH linux-next] x86:lbr: fix boolreturn.cocci warnings
From: CGEL <hidden>
Date: 2021-08-24 07:07:59
Also in:
lkml
Subsystem:
performance events subsystem, the rest, x86 architecture (32-bit and 64-bit) · Maintainers:
Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Linus Torvalds, Thomas Gleixner, Borislav Petkov, Dave Hansen
From: Jing Yangyang <redacted> ./arch/x86/events/intel/lbr.c:925:9-10:WARNING: return of 0/1 in function 'get_lbr_mispred' with return type bool ./arch/x86/events/intel/lbr.c:933:9-10:WARNING: return of 0/1 in function 'get_lbr_predicted' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Reported-by: Zeal Robot <redacted> Signed-off-by: Jing Yangyang <redacted> --- arch/x86/events/intel/lbr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c
index 9e6d6ea..c803282 100644
--- a/arch/x86/events/intel/lbr.c
+++ b/arch/x86/events/intel/lbr.c@@ -922,7 +922,7 @@ static __always_inline int get_lbr_br_type(u64 info) static __always_inline bool get_lbr_mispred(u64 info) { if (static_cpu_has(X86_FEATURE_ARCH_LBR) && !x86_pmu.lbr_mispred) - return 0; + return false; return !!(info & LBR_INFO_MISPRED); }
@@ -930,7 +930,7 @@ static __always_inline bool get_lbr_mispred(u64 info) static __always_inline bool get_lbr_predicted(u64 info) { if (static_cpu_has(X86_FEATURE_ARCH_LBR) && !x86_pmu.lbr_mispred) - return 0; + return false; return !(info & LBR_INFO_MISPRED); }
--
1.8.3.1